Skip to content

Obsolete UseAzureSignalR #1605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 8, 2022
Merged

Obsolete UseAzureSignalR #1605

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9c00d39
Obsolete IApplicationBuilder.UseAzureSignalR when .NET Core version >…
xingsy97 May 10, 2022
90a84bb
update how to obsolete UseAzureSignalR
xingsy97 May 13, 2022
149a543
update UseAzureSignalR obsolete annotation
xingsy97 May 16, 2022
de10ac2
Update src/Microsoft.Azure.SignalR/ApplicationBuilderExtensions.cs
xingsy97 May 17, 2022
de5ce8f
Merge branch 'dev' into obsolete-UseAzureSignalR
xingsy97 Jun 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/Microsoft.Azure.SignalR/ApplicationBuilderExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,9 @@ public static class AzureSignalRApplicationBuilderExtensions
/// <param name="app">The <see cref="IApplicationBuilder"/>.</param>
/// <param name="configure">A callback to configure the <see cref="ServiceRouteBuilder"/>.</param>
/// <returns>The same instance of the <see cref="IApplicationBuilder"/> for chaining.</returns>
#if !NETSTANDARD2_0
[Obsolete("IApplicationBuilder.UseAzureSignalR is obsoleted, please use IApplicationBuilder.UseEndpoints() instead.")]
#endif
public static IApplicationBuilder UseAzureSignalR(this IApplicationBuilder app, Action<ServiceRouteBuilder> configure)
{
var marker = app.ApplicationServices.GetService<AzureSignalRMarkerService>();
Expand Down
2 changes: 1 addition & 1 deletion test/Microsoft.Azure.SignalR.E2ETests/SignalR/TestStartup.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ public TestStartup(IConfiguration configuration)

public void Configure(IApplicationBuilder app)
{
app.UseAzureSignalR(configure =>
app.UseEndpoints(configure =>
{
configure.MapHub<TestHub>($"/{nameof(TestHub)}");
});
Expand Down