Improve server status ping sent to start after connection container is ready (#2070)

* Improve server status ping sent to start after connection container is ready

* fix tests

Author: vicancy

src/Microsoft.Azure.SignalR.Common/ServiceConnections/ServiceConnectionBase.cs

@@ -714,7 +714,7 @@ private async Task KeepAliveAsync(TimerAwaitable timer)
 
             while (await timer)
             {
-                if (Stopwatch.GetTimestamp() - Interlocked.Read(ref _lastReceiveTimestamp) > DefaultServiceTimeoutTicks)
+                if (!Debugger.IsAttached && Stopwatch.GetTimestamp() - Interlocked.Read(ref _lastReceiveTimestamp) > DefaultServiceTimeoutTicks)
                 {
                     Log.ServiceTimeout(Logger, _endpointName, DefaultServiceTimeout, ConnectionId);
                     await StopAsync();

src/Microsoft.Azure.SignalR.Common/ServiceConnections/ServiceConnectionContainerBase.cs

@@ -159,7 +159,7 @@ protected ServiceConnectionContainerBase(IServiceConnectionFactory serviceConnec
         // when server connection count is specified to 0, the app server only handle negotiate requests
         if (initial.Count > 0)
         {
-            _statusPing.Start();
+            _ = StartStatusPing();
         }
 
         _serversPing = new CustomizedPingTimer(Logger, Constants.CustomizedPingTimer.Servers, WriteServersPingAsync, Constants.Periods.DefaultServersPingInterval, Constants.Periods.DefaultServersPingInterval);
@@ -420,6 +420,12 @@ protected async Task RemoveConnectionAsync(IServiceConnection c, GracefulShutdow
         Log.TimeoutWaitingForFinAck(Logger, retry);
     }
 
+    private async Task StartStatusPing()
+    {
+        await this.ConnectionInitializedTask.ConfigureAwait(false);
+        _statusPing.Start();
+    }
+
     private async Task WriteMessageAsync(ServiceMessage serviceMessage)
     {
         var connection = SelectConnection(serviceMessage);

test/Microsoft.Azure.SignalR.Tests/ServiceConnectionContainerBaseTests.cs

@@ -50,7 +50,7 @@ public async Task TestServersPing(int startCount, int stopCount, int expectedWar
                     logger: loggerFactory.CreateLogger<TestServiceConnectionContainer>());
 
             await container.StartAsync();
-
+            await container.ConnectionInitializedTask;
             var tasks = new List<Task>();
 
             while (startCount > 0)
@@ -111,6 +111,7 @@ public async Task TestServersPingWorkSecondTime(int firstStart, int firstStop, i
                     logger: loggerFactory.CreateLogger<TestServiceConnectionContainer>());
 
             await container.StartAsync();
+            await container.ConnectionInitializedTask;
 
             var tasks = new List<Task>();
 

test/Microsoft.Azure.SignalR.Tests/ServiceLifetimeManagerFacts.cs

@@ -141,16 +141,16 @@ public async void ServiceLifetimeManagerIntegrationTest(string methodName, Type
 
         var invokeTask = InvokeMethod(serviceLifetimeManager, methodName);
 
+        var message = await task.OrTimeout();
+
         if (typeof(IAckableMessage).IsAssignableFrom(messageType))
         {
-            await proxy.WriteMessageAsync(new AckMessage(1, (int)AckStatus.Ok));
+            await proxy.WriteMessageAsync(new AckMessage((message as IAckableMessage).AckId, (int)AckStatus.Ok));
         }
 
         // Need to return in time, or it indicate a timeout when sending ack-able messages.
         await invokeTask.OrTimeout();
 
-        var message = await task.OrTimeout();
-
         VerifyServiceMessage(methodName, message);
     }