update CallerClientResultsManager (#1697)

add `TryCompleteResult` for `ErrorCompletionMessage`

Author: xingsy97

src/Microsoft.Azure.SignalR.Common/ClientInvocation/ICallerClientResultsManager.cs

@@ -27,5 +27,7 @@ internal interface ICallerClientResultsManager : IClientResultsManager
         void CleanupInvocationsByInstance(string instanceId);
 
         bool TryCompleteResult(string connectionId, ClientCompletionMessage message);
+
+        bool TryCompleteResult(string connectionId, ErrorCompletionMessage message);
     }
 }

src/Microsoft.Azure.SignalR/ClientInvocation/CallerClientResultsManager.cs

@@ -87,7 +87,7 @@ public void CleanupInvocationsByInstance(string instanceId)
             {
                 if (invocation.RouterInstanceId == instanceId)
                 {
-                    var message = new CompletionMessage(invocationId, $"Connection '{invocation.ConnectionId}' is disconnected.", null, false);
+                    var message = CompletionMessage.WithError(invocationId, $"Connection '{invocation.ConnectionId}' is disconnected.");
 
                     invocation.Complete(invocation.Tcs, message);
                     _pendingInvocations.TryRemove(invocationId, out _);
@@ -128,7 +128,7 @@ public bool TryCompleteResult(string connectionId, ClientCompletionMessage messa
             if (protocol == null)
             {
                 var errorMessage = $"Not supported protocol {message.Protocol} by server.";
-                return TryCompleteResult(connectionId, new CompletionMessage(message.InvocationId, errorMessage, null, false));
+                return TryCompleteResult(connectionId, CompletionMessage.WithError(message.InvocationId, errorMessage));
             }
 
             var payload = message.Payload;
@@ -146,6 +146,12 @@ public bool TryCompleteResult(string connectionId, ClientCompletionMessage messa
             return false;
         }
 
+        public bool TryCompleteResult(string connectionId, ErrorCompletionMessage message)
+        {
+            var errorMessage = CompletionMessage.WithError(message.InvocationId, message.Error);
+            return TryCompleteResult(connectionId, errorMessage);
+        }
+
         // Implemented for interface IInvocationBinder
         public Type GetReturnType(string invocationId)
         {