Rename to Named... (#1915)

Author: vicancy

src/Microsoft.Azure.SignalR/DependencyInjectionExtensions.cs

@@ -37,12 +37,12 @@ public static ISignalRServerBuilder AddAzureSignalR(this ISignalRServerBuilder b
         }
 
         /// <summary>
-        /// Add Azure SignalR with specified connection name, the connection string could be read from ConnectionStrings_{name}, the settings are loaded from Azure:SignalR:{name} section
+        /// Add Azure SignalR with specified name, the connection string will be read from ConnectionStrings_{name}, the settings are loaded from Azure:SignalR:{name} section
         /// </summary>
         /// <param name="builder">The <see cref="ISignalRServerBuilder"/>.</param>
         /// <param name="name">The name of the Azure SignalR service that settings and connection strings are read from</param>
         /// <returns>The same instance of the <see cref="ISignalRServerBuilder"/> for chaining.</returns>
-        public static ISignalRServerBuilder AddAzureSignalRWithConnectionName(this ISignalRServerBuilder builder, string name)
+        public static ISignalRServerBuilder AddNamedAzureSignalR(this ISignalRServerBuilder builder, string name)
         {
             if (string.IsNullOrEmpty(name))
             {

test/Microsoft.Azure.SignalR.Tests/AddAzureSignalRWithConnectionNameFacts.cs

@@ -48,7 +48,7 @@ public void AddAzureSignalRWithConnectionNameWithEmptyConnectionNameThrows()
                     })
                     .Build();
                 Assert.Throws<ArgumentException>(() => services.AddSignalR()
-                    .AddAzureSignalRWithConnectionName("")
+                    .AddNamedAzureSignalR("")
                     .Services
                     .AddSingleton<IConfiguration>(config)
                     .AddSingleton(loggerFactory)
@@ -69,7 +69,7 @@ public void AddAzureSignalRWithConnectionNameReadsFromConnectionStringsCorrectly
                     })
                     .Build();
                 var serviceProvider = services.AddSignalR()
-                    .AddAzureSignalRWithConnectionName("s1")
+                    .AddNamedAzureSignalR("s1")
                     .Services
                     .AddSingleton<IConfiguration>(config)
                     .AddSingleton(loggerFactory)
@@ -94,7 +94,7 @@ public void AddAzureSignalRWithConnectionNameConnectionStringCanBeSetInCode()
                     })
                     .Build();
                 var serviceProvider = services.AddSignalR()
-                    .AddAzureSignalRWithConnectionName("s1")
+                    .AddNamedAzureSignalR("s1")
                     .Services
                     .Configure<ServiceOptions>(s => s.ConnectionString = CustomValue)
                     .AddSingleton<IConfiguration>(config)
@@ -122,7 +122,7 @@ public void AddAzureSignalRWithConnectionNameConnectionNameWinsOverConfigSection
                     })
                     .Build();
                 var serviceProvider = services.AddSignalR()
-                    .AddAzureSignalRWithConnectionName("s1")
+                    .AddNamedAzureSignalR("s1")
                     .Services
                     .AddSingleton<IConfiguration>(config)
                     .AddSingleton(loggerFactory)
@@ -148,7 +148,7 @@ public void AddAzureSignalRWithConnectionNameReadsDefaultConfigurationKeyForConn
                     })
                     .Build();
                 var serviceProvider = services.AddSignalR()
-                    .AddAzureSignalRWithConnectionName("name1")
+                    .AddNamedAzureSignalR("name1")
                     .Services
                     .AddSingleton<IConfiguration>(config)
                     .AddSingleton(loggerFactory)
@@ -173,7 +173,7 @@ public void AddAzureSignalRWithConnectionNameReadsInvalidCongifurationThrows()
                 var config = new ConfigurationBuilder()
                     .Build();
                 var serviceProvider = services.AddSignalR()
-                    .AddAzureSignalRWithConnectionName("name1")
+                    .AddNamedAzureSignalR("name1")
                     .Services
                     .Configure<ServiceOptions>(o =>
                     {
@@ -206,7 +206,7 @@ public void AddAzureSignalRWithConnectionNameIgnoreDefaultConnectionString()
                     })
                     .Build();
                 var serviceProvider = services.AddSignalR()
-                    .AddAzureSignalRWithConnectionName("name1")
+                    .AddNamedAzureSignalR("name1")
                     .Services
                     .AddSingleton<IConfiguration>(config)
                     .AddSingleton(loggerFactory)
@@ -234,7 +234,7 @@ public void AddAzureSignalRWithConnectionNameIgnoreDefaultConnectionStringDefaul
                     })
                     .Build();
                 var serviceProvider = services.AddSignalR()
-                    .AddAzureSignalRWithConnectionName("name1")
+                    .AddNamedAzureSignalR("name1")
                     .Services
                     .AddSingleton<IConfiguration>(config)
                     .AddSingleton(loggerFactory)
@@ -267,7 +267,7 @@ public void AddAzureOptionsFromConfiguration()
                     })
                     .Build();
                 var serviceProvider = services.AddSignalR()
-                    .AddAzureSignalRWithConnectionName("s1")
+                    .AddNamedAzureSignalR("s1")
                     .Services
                     .AddSingleton<IConfiguration>(config)
                     .AddSingleton(loggerFactory)
@@ -303,7 +303,7 @@ public void AddAzureReadsConnectionStringFirst()
                     .Build();
                 string capturedConnectionString = null;
                 var serviceProvider = services.AddSignalR()
-                    .AddAzureSignalRWithConnectionName("s2")
+                    .AddNamedAzureSignalR("s2")
                     .Services
                     .Configure<ServiceOptions>(o => { capturedConnectionString = o.ConnectionString; })
                     .AddSingleton<IConfiguration>(config)
@@ -336,7 +336,7 @@ public void AddAzureSignalRWithConnectionNameLoadConnectionStringOrder(string cu
                     })
                     .Build();
                 var serviceProvider = services.AddSignalR()
-                    .AddAzureSignalRWithConnectionName("s1")
+                    .AddNamedAzureSignalR("s1")
                     .Services
                     .Configure<ServiceOptions>(o =>
                     {
@@ -373,7 +373,7 @@ public void AddAzureSignalRWithConnectionNameReadServiceEndpointsFromConfig(stri
                     })
                     .Build();
                 var serviceProvider = services.AddSignalR()
-                    .AddAzureSignalRWithConnectionName("s1")
+                    .AddNamedAzureSignalR("s1")
                     .Services
                     .Configure<ServiceOptions>(o =>
                     {
@@ -438,7 +438,7 @@ public void AddAzureSignalRWithConnectionNameWithOnlySecondaryValueThrows(string
                     })
                     .Build();
                 var serviceProvider = services.AddSignalR()
-                    .AddAzureSignalRWithConnectionName("s1")
+                    .AddNamedAzureSignalR("s1")
                     .Services
                     .Configure<ServiceOptions>(o =>
                     {
@@ -485,7 +485,7 @@ public void AddAzureSignalRWithConnectionNameCustomizeEndpointsOverridesConfigVa
                     })
                     .Build();
                 var serviceProvider = services.AddSignalR()
-                    .AddAzureSignalRWithConnectionName("s1")
+                    .AddNamedAzureSignalR("s1")
                     .Services
                     .Configure<ServiceOptions>(o =>
                     {