Resolve comments

Author: vicancy

src/Microsoft.Azure.SignalR.Protocols/MessagePackUtils.cs

@@ -161,7 +161,7 @@ internal static string[] ReadStringArrayExcludeNull(ref MessagePackReader reader
         var arrayLength = ReadArrayLength(ref reader, field);
         if (arrayLength > 0)
         {
-            var list = new List<string>();
+            var list = new List<string>(arrayLength);
             for (int i = 0; i < arrayLength; i++)
             {
                 var fieldName = $"{field}[{i}]";
@@ -174,7 +174,6 @@ internal static string[] ReadStringArrayExcludeNull(ref MessagePackReader reader
 
             return [.. list];
         }
-
         return [];
     }
 
@@ -226,7 +225,7 @@ internal static long ReadMapLength(ref MessagePackReader reader, string field)
         }
     }
 
-    internal static long ReadArrayLength(ref MessagePackReader reader, string field)
+    internal static int ReadArrayLength(ref MessagePackReader reader, string field)
     {
         try
         {

test/Microsoft.Azure.SignalR.Protocols.Tests/ServiceMessageEqualityComparer.cs

@@ -487,43 +487,14 @@ private static bool HeadersEqual(IDictionary<string, StringValues> x, IDictionar
             return true;
         }
 
-        private static bool MoveUntilNotNull(IEnumerator enumerator)
+        private static bool SequenceEqualSkipNull<T>(IEnumerable<T> leftEnumerable, IEnumerable<T> rightEnumerable)
         {
-            var moveNext = enumerator.MoveNext();
-            while (moveNext && enumerator.Current == null)
-            {
-                moveNext = enumerator.MoveNext();
-            }
-            return moveNext;
-        }
-
-        private static bool SequenceEqualSkipNull(object left, object right)
-        {
-            if (left == null && right == null)
-            {
-                return true;
-            }
-
-            var leftEnumerable = left as IEnumerable;
-            var rightEnumerable = right as IEnumerable;
             if (leftEnumerable == null || rightEnumerable == null)
             {
                 return false;
             }
 
-            var leftEnumerator = leftEnumerable.GetEnumerator();
-            var rightEnumerator = rightEnumerable.GetEnumerator();
-            var leftMoved = MoveUntilNotNull(leftEnumerator);
-            var rightMoved = MoveUntilNotNull(rightEnumerator);
-            for (; leftMoved && rightMoved; leftMoved = MoveUntilNotNull(leftEnumerator), rightMoved = MoveUntilNotNull(rightEnumerator))
-            {
-                if (!Equals(leftEnumerator.Current, rightEnumerator.Current))
-                {
-                    return false;
-                }
-            }
-
-            return !leftMoved && !rightMoved;
+            return leftEnumerable.Where(x => x != null).Zip(rightEnumerable.Where(x => x != null), (x, y) => Equals(x, y)).All(z => z);
         }
 
         private static bool SequenceEqual(object left, object right)