Lower EndpointOffline to warning

Author: vicancy

src/Microsoft.Azure.SignalR.Common/ServiceConnections/Internal/WebSocketsTransport.cs

@@ -49,7 +49,6 @@ public WebSocketsTransport(WebSocketConnectionOptions connectionOptions,
     {
         _logger = (loggerFactory ?? throw new ArgumentNullException(nameof(loggerFactory))).CreateLogger<WebSocketsTransport>();
         _webSocket = new ClientWebSocket();
-
         // Issue in ClientWebSocket prevents user-agent being set - https://github.com/dotnet/corefx/issues/26627
         //_webSocket.Options.SetRequestHeader("User-Agent", Constants.UserAgentHeader.ToString());
 
@@ -88,6 +87,8 @@ public WebSocketsTransport(WebSocketConnectionOptions connectionOptions,
                 _webSocket.Options.UseDefaultCredentials = connectionOptions.UseDefaultCredentials.Value;
             }
 
+            
+
             connectionOptions.WebSocketConfiguration?.Invoke(_webSocket.Options);
 
             _closeTimeout = connectionOptions.CloseTimeout;

src/Microsoft.Azure.SignalR.Common/ServiceConnections/ServiceConnectionContainerBase.cs

@@ -758,7 +758,7 @@ private static class Log
             LoggerMessage.Define<string, string>(LogLevel.Information, new EventId(1, "EndpointOnline"), "Hub '{hub}' is now connected to '{endpoint}'.");
 
         private static readonly Action<ILogger, string, string, Exception> _endpointOffline =
-            LoggerMessage.Define<string, string>(LogLevel.Error, new EventId(2, "EndpointOffline"), "Hub '{hub}' is now disconnected from '{endpoint}'. Please check log for detailed info.");
+            LoggerMessage.Define<string, string>(LogLevel.Warning, new EventId(2, "EndpointOffline"), "Hub '{hub}' is now disconnected from '{endpoint}'. Please check log for detailed info.");
 
         private static readonly Action<ILogger, Exception> _receivedFinAckPing =
             LoggerMessage.Define(LogLevel.Information, new EventId(3, "ReceivedFinAckPing"), "Received FinAck ping.");

test/Microsoft.Azure.SignalR.Tests/RunSignalRTests.cs

@@ -69,7 +69,7 @@ public async Task TestRunSignalRWithSimpleHub()
         Assert.NotNull(connectionDisconnectLog);
         Assert.Equal("conn1 disconnected: .", connectionDisconnectLog.Write.Message);
 
-        Assert.Empty(logs.Where(s => s.Write.LogLevel == LogLevel.Warning));
+        Assert.Empty(logs.Where(s => s.Write.LogLevel == LogLevel.Warning && s.Write.EventId.Name != "EndpointOffline").Select(s => s.Write.EventId.Name));
     }
 
     [Fact]
@@ -108,7 +108,8 @@ public async Task TestRunSignalRWithSimpleHubAndMultipleConnections()
         Assert.Equal(0, logs.Count(s => s.Write.EventId.Name == "DetectedLongRunningApplicationTask"));
 
         Assert.Equal(count, logs.Count(s => s.Write.LoggerName == typeof(SimpleHub).FullName));
-        Assert.Empty(logs.Where(s => s.Write.LogLevel == LogLevel.Warning));
+
+        Assert.Empty(logs.Where(s => s.Write.LogLevel == LogLevel.Warning && s.Write.EventId.Name != "EndpointOffline").Select(s => s.Write.EventId.Name));
     }
 
     [Fact]
@@ -146,7 +147,7 @@ public async Task TestRunSignalRWithConnectedSendingMessages()
         var connectionDisconnectLog = logs.FirstOrDefault(s => s.Write.LoggerName == typeof(ConnectedHub).FullName);
         Assert.NotNull(connectionDisconnectLog);
         Assert.Equal("conn1 disconnected: .", connectionDisconnectLog.Write.Message);
-        Assert.Empty(logs.Where(s => s.Write.LogLevel == LogLevel.Warning && s.Write.EventId.Name != "DetectedLongRunningApplicationTask").Select(s => s.Write.EventId.Name));
+        Assert.Empty(logs.Where(s => s.Write.LogLevel == LogLevel.Warning && s.Write.EventId.Name != "DetectedLongRunningApplicationTask" && s.Write.EventId.Name != "EndpointOffline").Select(s => s.Write.EventId.Name));
     }
 
     private sealed class TestStartup<THub> : IStartup