Remove generated REST client which depends on deprecated package. (#1902)

* For `RestHealthCheckService` (not really used now), the HttpClient timeout is not impacted by user settings.
* For `ServiceManager.IsServiceHeathy`, the http client timeout is impacted by user settings.
* For AAD related REST API calls, because they use a static `HttpClientFactory` instance, they have never impacted by the user settings.

Author: Y-Sindo

Directory.Build.props

@@ -74,7 +74,6 @@
     <SignedPackageFile Include="$(PublishDir)Microsoft.IdentityModel.Protocols.OpenIdConnect.dll" Certificate="$(AssemblySigningCertName)" Visible="false" />
     <SignedPackageFile Include="$(PublishDir)Microsoft.IdentityModel.Protocols.dll" Certificate="$(AssemblySigningCertName)" Visible="false" />
     <SignedPackageFile Include="$(PublishDir)Microsoft.IdentityModel.Tokens.dll" Certificate="$(AssemblySigningCertName)" Visible="false" />
-    <SignedPackageFile Include="$(PublishDir)Microsoft.Rest.ClientRuntime.dll" Certificate="$(AssemblySigningCertName)" Visible="false"  />
     <SignedPackageFile Include="$(PublishDir)Newtonsoft.Json.Bson.dll" Certificate="$(AssemblySigningCertName)" Visible="false" />
     <SignedPackageFile Include="$(PublishDir)Newtonsoft.Json.dll" Certificate="$(AssemblySigningCertName)" Visible="false" />
     <SignedPackageFile Include="$(PublishDir)System.IO.Pipelines.dll" Certificate="$(AssemblySigningCertName)" Visible="false" />

build/dependencies.props

@@ -25,7 +25,6 @@
     <MicrosoftExtensionsLoggingPackageVersion>2.1.0</MicrosoftExtensionsLoggingPackageVersion>
     <MicrosoftExtensionsPrimitivesPackageVersion>2.1.1</MicrosoftExtensionsPrimitivesPackageVersion>
     <MicrosoftAspNetCoreSignalRClient>1.1.0</MicrosoftAspNetCoreSignalRClient>
-    <MicrosoftRestClientRuntimePackageVersion>2.3.24</MicrosoftRestClientRuntimePackageVersion>
 
     <!--Security Patch-->
     <!-- Fix risks from Microsoft.AspNetCore.SignalR 1.0.0-->

src/Directory.Build.props

@@ -26,7 +26,6 @@
 
   <ItemGroup Condition=" '$(OutputType)' != 'Exe'">
     <PackageReference Include="Microsoft.Extensions.Http" Version="$(MicrosoftExtensionHttpVersion)" />
-    <PackageReference Include="Microsoft.Rest.ClientRuntime" Version="$(MicrosoftRestClientRuntimePackageVersion)" />
     <PackageReference Include="Azure.Identity" Version="$(AzureIdentityPackageVersion)" />
     <PackageReference Include="Newtonsoft.Json" Version="$(NewtonsoftJsonPackageVersion)" />
   </ItemGroup>

src/Microsoft.Azure.SignalR.Common/Constants.cs

@@ -113,6 +113,8 @@ public static class HttpClientNames
         {
             public const string Resilient = "Resilient";
             public const string MessageResilient = "MessageResilient";
+            public const string UserDefault = "UserDefault";
+            public const string InternalDefault = "InternalDefault";
         }
     }
 }

src/Microsoft.Azure.SignalR.Common/Exceptions/ExceptionExtensions.cs

@@ -2,42 +2,12 @@
 // Licensed under the MIT license. See LICENSE file in the project root for full license information.
 
 using System;
-using System.Net;
-using System.Net.Http;
 using System.Net.WebSockets;
 
-using Microsoft.Rest;
-
 namespace Microsoft.Azure.SignalR.Common
 {
     internal static class ExceptionExtensions
     {
-        internal static Exception WrapAsAzureSignalRException(this Exception e, Uri baseUri)
-        {
-            switch (e)
-            {
-                case HttpOperationException operationException:
-                    var response = operationException.Response;
-                    var request = operationException.Request;
-                    var detail = response.Content;
-
-                    var innerException = new HttpRequestException(
-                        $"Response status code does not indicate success: {(int)response.StatusCode} ({response.ReasonPhrase})", operationException);
-
-                    return response.StatusCode switch
-                    {
-                        HttpStatusCode.BadRequest => new AzureSignalRInvalidArgumentException(request.RequestUri.ToString(), innerException, detail),
-                        HttpStatusCode.Unauthorized => new AzureSignalRUnauthorizedException(request.RequestUri.ToString(), innerException),
-                        HttpStatusCode.NotFound => new AzureSignalRInaccessibleEndpointException(request.RequestUri.ToString(), innerException),
-                        _ => new AzureSignalRRuntimeException(baseUri.ToString(), innerException),
-                    };
-                case HttpRequestException requestException:
-                    return new AzureSignalRInaccessibleEndpointException(baseUri.ToString(), requestException);
-                default:
-                    return e;
-            }
-        }
-
         internal static Exception WrapAsAzureSignalRException(this Exception e)
         {
             switch (e)