Apply comprehensive hardcoded strings fix to async versions: complete constants implementation across all Cosmos SDK files

Co-authored-by: bambriz <[email protected]>

Author: Copilot

sdk/cosmos/azure-cosmos/azure/cosmos/aio/_container.py

@@ -265,13 +265,13 @@ async def create_item(
         :returns: A CosmosDict representing the new item. The dict will be empty if `no_response` is specified.
         :rtype: ~azure.cosmos.CosmosDict[str, Any]
         """
-        etag = kwargs.get('etag')
+        etag = kwargs.get(Constants.Kwargs.ETAG)
         if etag is not None:
             warnings.warn(
                 "The 'etag' flag does not apply to this method and is always ignored even if passed."
                 " It will now be removed in the future.",
                 DeprecationWarning)
-        match_condition = kwargs.get('match_condition')
+        match_condition = kwargs.get(Constants.Kwargs.MATCH_CONDITION)
         if match_condition is not None:
             warnings.warn(
                 "The 'match_condition' flag does not apply to this method and is always ignored even if passed."
@@ -1040,9 +1040,9 @@ async def upsert_item(
         if priority is not None:
             kwargs[Constants.Kwargs.PRIORITY] = priority
         if etag is not None:
-            kwargs['etag'] = etag
+            kwargs[Constants.Kwargs.ETAG] = etag
         if match_condition is not None:
-            kwargs['match_condition'] = match_condition
+            kwargs[Constants.Kwargs.MATCH_CONDITION] = match_condition
         if no_response is not None:
             kwargs[Constants.Kwargs.NO_RESPONSE] = no_response
         if retry_write is not None:
@@ -1131,9 +1131,9 @@ async def replace_item(
         if priority is not None:
             kwargs[Constants.Kwargs.PRIORITY] = priority
         if etag is not None:
-            kwargs['etag'] = etag
+            kwargs[Constants.Kwargs.ETAG] = etag
         if match_condition is not None:
-            kwargs['match_condition'] = match_condition
+            kwargs[Constants.Kwargs.MATCH_CONDITION] = match_condition
         if no_response is not None:
             kwargs[Constants.Kwargs.NO_RESPONSE] = no_response
         if retry_write is not None:
@@ -1220,9 +1220,9 @@ async def patch_item(
         if priority is not None:
             kwargs[Constants.Kwargs.PRIORITY] = priority
         if etag is not None:
-            kwargs['etag'] = etag
+            kwargs[Constants.Kwargs.ETAG] = etag
         if match_condition is not None:
-            kwargs['match_condition'] = match_condition
+            kwargs[Constants.Kwargs.MATCH_CONDITION] = match_condition
         if no_response is not None:
             kwargs[Constants.Kwargs.NO_RESPONSE] = no_response
         if retry_write is not None:
@@ -1303,9 +1303,9 @@ async def delete_item(
         if initial_headers is not None:
             kwargs[Constants.Kwargs.INITIAL_HEADERS] = initial_headers
         if etag is not None:
-            kwargs['etag'] = etag
+            kwargs[Constants.Kwargs.ETAG] = etag
         if match_condition is not None:
-            kwargs['match_condition'] = match_condition
+            kwargs[Constants.Kwargs.MATCH_CONDITION] = match_condition
         if priority is not None:
             kwargs[Constants.Kwargs.PRIORITY] = priority
         if retry_write is not None:
@@ -1559,13 +1559,13 @@ async def delete_all_items_by_partition_key(
         :keyword int throughput_bucket: The desired throughput bucket for the client
         :rtype: None
         """
-        etag = kwargs.get('etag')
+        etag = kwargs.get(Constants.Kwargs.ETAG)
         if etag is not None:
             warnings.warn(
                 "The 'etag' flag does not apply to this method and is always ignored even if passed."
                 " It will now be removed in the future.",
                 DeprecationWarning)
-        match_condition = kwargs.get('match_condition')
+        match_condition = kwargs.get(Constants.Kwargs.MATCH_CONDITION)
         if match_condition is not None:
             warnings.warn(
                 "The 'match_condition' flag does not apply to this method and is always ignored even if passed."
@@ -1627,13 +1627,13 @@ async def execute_item_batch(
         :raises ~azure.cosmos.exceptions.CosmosBatchOperationError: A transactional batch operation failed in the batch.
         :rtype: ~azure.cosmos.CosmosList[Dict[str, Any]]
         """
-        etag = kwargs.get('etag')
+        etag = kwargs.get(Constants.Kwargs.ETAG)
         if etag is not None:
             warnings.warn(
                 "The 'etag' flag does not apply to this method and is always ignored even if passed."
                 " It will now be removed in the future.",
                 DeprecationWarning)
-        match_condition = kwargs.get('match_condition')
+        match_condition = kwargs.get(Constants.Kwargs.MATCH_CONDITION)
         if match_condition is not None:
             warnings.warn(
                 "The 'match_condition' flag does not apply to this method and is always ignored even if passed."

sdk/cosmos/azure-cosmos/azure/cosmos/aio/_cosmos_client.py

@@ -174,7 +174,7 @@ class CosmosClient:  # pylint: disable=client-accepts-api-version-keyword
         Must be used along with a logger to work.
     :keyword ~logging.Logger logger: Logger to be used for collecting request diagnostics. Can be passed in at client
         level (to log all requests) or at a single request level. Requests will be logged at INFO level.
-    :keyword bool no_response_on_write: Indicates whether service should be instructed to skip sending 
+    :keyword bool no_response_on_write: Indicates whether service should be instructed to skip sending
         response payloads for write operations on items by default unless specified differently per operation.
     :keyword int throughput_bucket: The desired throughput bucket for the client
     :keyword str user_agent_suffix: Allows user agent suffix to be specified when creating client
@@ -295,13 +295,13 @@ async def create_database(
                 "The 'session_token' flag does not apply to this method and is always ignored even if passed."
                 " It will now be removed in the future.",
                 DeprecationWarning)
-        etag = kwargs.get('etag')
+        etag = kwargs.get(Constants.Kwargs.ETAG)
         if etag is not None:
             warnings.warn(
                 "The 'etag' flag does not apply to this method and is always ignored even if passed."
                 " It will now be removed in the future.",
                 DeprecationWarning)
-        match_condition = kwargs.get('match_condition')
+        match_condition = kwargs.get(Constants.Kwargs.MATCH_CONDITION)
         if match_condition is not None:
             warnings.warn(
                 "The 'match_condition' flag does not apply to this method and is always ignored even if passed."
@@ -353,13 +353,13 @@ async def create_database_if_not_exists(  # pylint: disable=redefined-builtin
                 "The 'session_token' flag does not apply to this method and is always ignored even if passed."
                 " It will now be removed in the future.",
                 DeprecationWarning)
-        etag = kwargs.get('etag')
+        etag = kwargs.get(Constants.Kwargs.ETAG)
         if etag is not None:
             warnings.warn(
                 "The 'etag' flag does not apply to this method and is always ignored even if passed."
                 " It will now be removed in the future.",
                 DeprecationWarning)
-        match_condition = kwargs.get('match_condition')
+        match_condition = kwargs.get(Constants.Kwargs.MATCH_CONDITION)
         if match_condition is not None:
             warnings.warn(
                 "The 'match_condition' flag does not apply to this method and is always ignored even if passed."
@@ -430,7 +430,7 @@ def list_databases(
             kwargs[Constants.Kwargs.THROUGHPUT_BUCKET] = throughput_bucket
         feed_options = _build_options(kwargs)
         if max_item_count is not None:
-            feed_options["maxItemCount"] = max_item_count
+            feed_options[Constants.InternalOptions.MAX_ITEM_COUNT] = max_item_count
 
         result = self.client_connection.ReadDatabases(options=feed_options, **kwargs)
         if response_hook:
@@ -476,7 +476,7 @@ def query_databases(
             kwargs[Constants.Kwargs.THROUGHPUT_BUCKET] = throughput_bucket
         feed_options = _build_options(kwargs)
         if max_item_count is not None:
-            feed_options["maxItemCount"] = max_item_count
+            feed_options[Constants.InternalOptions.MAX_ITEM_COUNT] = max_item_count
 
         result = self.client_connection.QueryDatabases(
             query=query if parameters is None else {"query": query, "parameters": parameters},
@@ -514,13 +514,13 @@ async def delete_database(
                 "The 'session_token' flag does not apply to this method and is always ignored even if passed."
                 " It will now be removed in the future.",
                 DeprecationWarning)
-        etag = kwargs.get('etag')
+        etag = kwargs.get(Constants.Kwargs.ETAG)
         if etag is not None:
             warnings.warn(
                 "The 'etag' flag does not apply to this method and is always ignored even if passed."
                 " It will now be removed in the future.",
                 DeprecationWarning)
-        match_condition = kwargs.get('match_condition')
+        match_condition = kwargs.get(Constants.Kwargs.MATCH_CONDITION)
         if match_condition is not None:
             warnings.warn(
                 "The 'match_condition' flag does not apply to this method and is always ignored even if passed."

sdk/cosmos/azure-cosmos/azure/cosmos/aio/_database.py

@@ -249,13 +249,13 @@ async def create_container(
                 "The 'session_token' flag does not apply to this method and is always ignored even if passed."
                 " It will now be removed in the future.",
                 DeprecationWarning)
-        etag = kwargs.get('etag')
+        etag = kwargs.get(Constants.Kwargs.ETAG)
         if etag is not None:
             warnings.warn(
                 "The 'etag' flag does not apply to this method and is always ignored even if passed."
                 " It will now be removed in the future.",
                 DeprecationWarning)
-        match_condition = kwargs.get('match_condition')
+        match_condition = kwargs.get(Constants.Kwargs.MATCH_CONDITION)
         if match_condition is not None:
             warnings.warn(
                 "The 'match_condition' flag does not apply to this method and is always ignored even if passed."
@@ -368,13 +368,13 @@ async def create_container_if_not_exists(
                 "The 'session_token' flag does not apply to this method and is always ignored even if passed."
                 " It will now be removed in the future.",
                 DeprecationWarning)
-        etag = kwargs.get('etag')
+        etag = kwargs.get(Constants.Kwargs.ETAG)
         if etag is not None:
             warnings.warn(
                 "The 'etag' flag does not apply to this method and is always ignored even if passed."
                 " It will now be removed in the future.",
                 DeprecationWarning)
-        match_condition = kwargs.get('match_condition')
+        match_condition = kwargs.get(Constants.Kwargs.MATCH_CONDITION)
         if match_condition is not None:
             warnings.warn(
                 "The 'match_condition' flag does not apply to this method and is always ignored even if passed."
@@ -474,7 +474,7 @@ def list_containers(
             kwargs[Constants.Kwargs.INITIAL_HEADERS] = initial_headers
         feed_options = _build_options(kwargs)
         if max_item_count is not None:
-            feed_options["maxItemCount"] = max_item_count
+            feed_options[Constants.InternalOptions.MAX_ITEM_COUNT] = max_item_count
 
         result = self.client_connection.ReadContainers(
             database_link=self.database_link, options=feed_options, **kwargs
@@ -519,7 +519,7 @@ def query_containers(
             kwargs[Constants.Kwargs.INITIAL_HEADERS] = initial_headers
         feed_options = _build_options(kwargs)
         if max_item_count is not None:
-            feed_options["maxItemCount"] = max_item_count
+            feed_options[Constants.InternalOptions.MAX_ITEM_COUNT] = max_item_count
 
         result = self.client_connection.QueryContainers(
             database_link=self.database_link,
@@ -593,13 +593,13 @@ async def replace_container(
                 "The 'session_token' flag does not apply to this method and is always ignored even if passed."
                 " It will now be removed in the future.",
                 DeprecationWarning)
-        etag = kwargs.get('etag')
+        etag = kwargs.get(Constants.Kwargs.ETAG)
         if etag is not None:
             warnings.warn(
                 "The 'etag' flag does not apply to this method and is always ignored even if passed."
                 " It will now be removed in the future.",
                 DeprecationWarning)
-        match_condition = kwargs.get('match_condition')
+        match_condition = kwargs.get(Constants.Kwargs.MATCH_CONDITION)
         if match_condition is not None:
             warnings.warn(
                 "The 'match_condition' flag does not apply to this method and is always ignored even if passed."
@@ -662,13 +662,13 @@ async def delete_container(
                 "The 'session_token' flag does not apply to this method and is always ignored even if passed."
                 " It will now be removed in the future.",
                 DeprecationWarning)
-        etag = kwargs.get('etag')
+        etag = kwargs.get(Constants.Kwargs.ETAG)
         if etag is not None:
             warnings.warn(
                 "The 'etag' flag does not apply to this method and is always ignored even if passed."
                 " It will now be removed in the future.",
                 DeprecationWarning)
-        match_condition = kwargs.get('match_condition')
+        match_condition = kwargs.get(Constants.Kwargs.MATCH_CONDITION)
         if match_condition is not None:
             warnings.warn(
                 "The 'match_condition' flag does not apply to this method and is always ignored even if passed."
@@ -768,7 +768,7 @@ def list_users(
         """
         feed_options = _build_options(kwargs)
         if max_item_count is not None:
-            feed_options["maxItemCount"] = max_item_count
+            feed_options[Constants.InternalOptions.MAX_ITEM_COUNT] = max_item_count
 
         result = self.client_connection.ReadUsers(
             database_link=self.database_link, options=feed_options, **kwargs
@@ -804,7 +804,7 @@ def query_users(
         """
         feed_options = _build_options(kwargs)
         if max_item_count is not None:
-            feed_options["maxItemCount"] = max_item_count
+            feed_options[Constants.InternalOptions.MAX_ITEM_COUNT] = max_item_count
 
         result = self.client_connection.QueryUsers(
             database_link=self.database_link,