Skip to content

Commit 5cb4a6d

Browse files
More git eol (#52040)
* add more formats * fix tests
1 parent 7a99cfa commit 5cb4a6d

File tree

5 files changed

+25
-15
lines changed

5 files changed

+25
-15
lines changed

.gitattributes

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,8 @@
1616
*.csproj text eol=lf
1717
*.sln text eol=lf
1818
*.sh text eol=lf
19+
*.json text eol=lf
20+
*.bicep text eol=lf
1921

2022
# Automatically collapse Track 2 test recordings in github PRs
2123
**/SessionRecords/**/*.json linguist-generated=true

sdk/cloudmachine/Azure.Projects.Provisioning/tests/BicepGenerationTests.cs

Lines changed: 16 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ public void MinimalProject()
2727
//File.WriteAllText(Path.Combine(Path.GetTempPath(), "minimal.bicep"), actualBicep);
2828

2929
string expectedBicep = LoadTestFile("minimal.bicep");
30-
Assert.AreEqual(expectedBicep, actualBicep);
30+
AssertEqual(expectedBicep, actualBicep);
3131
}
3232

3333
[Test]
@@ -44,7 +44,7 @@ public void MinimalProjectWithDeveloperAppConfig()
4444
//File.WriteAllText(Path.Combine(Path.GetTempPath(), "developer.bicep"), actualBicep);
4545

4646
string expectedBicep = LoadTestFile("developer.bicep");
47-
Assert.AreEqual(expectedBicep, actualBicep);
47+
AssertEqual(expectedBicep, actualBicep);
4848
}
4949

5050
[Test]
@@ -58,7 +58,7 @@ public void KeyVault()
5858
//File.WriteAllText(Path.Combine(Path.GetTempPath(), "kv.bicep"), actualBicep);
5959

6060
string expectedBicep = LoadTestFile("kv.bicep");
61-
Assert.AreEqual(expectedBicep, actualBicep);
61+
AssertEqual(expectedBicep, actualBicep);
6262
}
6363

6464
[Test]
@@ -72,7 +72,7 @@ public void Blobs()
7272
//File.WriteAllText(Path.Combine(Path.GetTempPath(), "blobs.bicep"), actualBicep);
7373

7474
string expectedBicep = LoadTestFile("blobs.bicep");
75-
Assert.AreEqual(expectedBicep, actualBicep);
75+
AssertEqual(expectedBicep, actualBicep);
7676
}
7777

7878
[Test]
@@ -87,7 +87,7 @@ public void BlobsTwoContainers()
8787
//File.WriteAllText(Path.Combine(Path.GetTempPath(), "blobs2Containers.bicep"), actualBicep);
8888

8989
string expectedBicep = LoadTestFile("blobs2Containers.bicep");
90-
Assert.AreEqual(expectedBicep, actualBicep);
90+
AssertEqual(expectedBicep, actualBicep);
9191
}
9292

9393
[Test]
@@ -101,7 +101,7 @@ public void BlobsObservableContainer()
101101
//File.WriteAllText(Path.Combine(Path.GetTempPath(), "blobsObservable.bicep"), actualBicep);
102102

103103
string expectedBicep = LoadTestFile("blobsObservable.bicep");
104-
Assert.AreEqual(expectedBicep, actualBicep);
104+
AssertEqual(expectedBicep, actualBicep);
105105
}
106106

107107
[Test]
@@ -116,7 +116,7 @@ public void OpenAI()
116116
//File.WriteAllText(Path.Combine(Path.GetTempPath(), "openai.bicep"), actualBicep);
117117

118118
string expectedBicep = LoadTestFile("openai.bicep");
119-
Assert.AreEqual(expectedBicep, actualBicep);
119+
AssertEqual(expectedBicep, actualBicep);
120120
}
121121

122122
[Test]
@@ -131,7 +131,7 @@ public void MaaS()
131131
//File.WriteAllText(path, actualBicep);
132132

133133
string expectedBicep = LoadTestFile("maas.bicep");
134-
Assert.AreEqual(expectedBicep, actualBicep);
134+
AssertEqual(expectedBicep, actualBicep);
135135
}
136136

137137
[Test]
@@ -145,7 +145,7 @@ public void ServiceBus()
145145
//File.WriteAllText(Path.Combine(Path.GetTempPath(), "sb.bicep"), actualBicep);
146146

147147
string expectedBicep = LoadTestFile("sb.bicep");
148-
Assert.AreEqual(expectedBicep, actualBicep);
148+
AssertEqual(expectedBicep, actualBicep);
149149
}
150150

151151
[Test]
@@ -159,7 +159,7 @@ public void Ofx()
159159
//File.WriteAllText(Path.Combine(Path.GetTempPath(), "cm.bicep"), actualBicep);
160160

161161
string expectedBicep = LoadTestFile("cm.bicep");
162-
Assert.AreEqual(expectedBicep, actualBicep);
162+
AssertEqual(expectedBicep, actualBicep);
163163
}
164164

165165
[Test]
@@ -176,7 +176,7 @@ public void AppService()
176176
//File.WriteAllText(Path.Combine(Path.GetTempPath(), "app.bicep"), actualBicep);
177177

178178
string expectedBicep = LoadTestFile("app.bicep");
179-
Assert.AreEqual(expectedBicep, actualBicep);
179+
AssertEqual(expectedBicep, actualBicep);
180180
}
181181

182182
private static string LoadTestFile(string filename)
@@ -188,4 +188,9 @@ private static string LoadTestFile(string filename)
188188
}
189189
return contents;
190190
}
191+
192+
private static void AssertEqual(string expectedBicep, string actualBicep)
193+
{
194+
Assert.AreEqual(expectedBicep, actualBicep.Replace("\r\n", "\n"));
195+
}
191196
}

sdk/cloudmachine/Azure.Projects.Provisioning/tests/Data/developer.bicep

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,4 +45,4 @@ resource projectConnection 'Microsoft.AppConfiguration/configurationStores/keyVa
4545
parent: appConfiguration
4646
}
4747

48-
output project_identity_id string = projectIdentity.id
48+
output project_identity_id string = projectIdentity.id

sdk/cloudmachine/Azure.Projects.Provisioning/tests/Data/maas.bicep

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -108,4 +108,4 @@ resource projectConnection2 'Microsoft.AppConfiguration/configurationStores/keyV
108108
parent: appConfiguration
109109
}
110110

111-
output project_identity_id string = projectIdentity.id
111+
output project_identity_id string = projectIdentity.id

sdk/core/System.ClientModel/tests/ModelReaderWriterTests/Models/ResourceProviderDataTests.cs

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ public void ValidatePrettyPrintWithStj()
6666

6767
var modelFromStj = JsonSerializer.Deserialize<ResourceProviderData>(WirePayload, stjOptions);
6868
var stjResult = JsonSerializer.Serialize(modelFromStj, stjOptions);
69-
Assert.AreEqual(File.ReadAllText(TestData.GetLocation("ResourceProviderData/ResourceProviderData-TwoSpaces.json")).TrimEnd(), stjResult);
69+
Assert.AreEqual(File.ReadAllText(TestData.GetLocation("ResourceProviderData/ResourceProviderData-TwoSpaces.json")).TrimEnd(), NormalizeLF(stjResult));
7070
}
7171

7272
[Test]
@@ -82,8 +82,11 @@ public void ValidateCapitalizationIsIgnored()
8282

8383
var modelFromStj = JsonSerializer.Deserialize<ResourceProviderData>(WirePayload, stjOptions);
8484
var stjResult = JsonSerializer.Serialize(modelFromStj, stjOptions);
85-
Assert.AreEqual(File.ReadAllText(TestData.GetLocation("ResourceProviderData/ResourceProviderData-TwoSpaces.json")).TrimEnd(), stjResult);
85+
Assert.AreEqual(File.ReadAllText(TestData.GetLocation("ResourceProviderData/ResourceProviderData-TwoSpaces.json")).TrimEnd(), NormalizeLF(stjResult));
8686
#endif
8787
}
88+
89+
private static string NormalizeLF(string s)
90+
=> s.Replace("\r\n", "\n");
8891
}
8992
}

0 commit comments

Comments
 (0)