Skip to content

Commit c281b96

Browse files
authored
Disable the compatibility verifier by default (#40407)
* Disable compatibility verifier
1 parent 29dfd74 commit c281b96

File tree

3 files changed

+6
-2
lines changed

3 files changed

+6
-2
lines changed

sdk/spring/CHANGELOG.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,9 @@ This section includes changes in `spring-cloud-azure-autoconfigure` module.
88
### Bugs Fixed
99
- Fixed `IllegalArgumentException: Subscription cannot be null` error when only configured one subscription name of `AzureServiceBusConsumerClient` or `AzureServiceBusProcessorClient` [#40264](https://github.com/Azure/azure-sdk-for-java/pull/40264).
1010

11+
### Other Changes
12+
- Disable compatibility verifier by default [#40407](https://github.com/Azure/azure-sdk-for-java/pull/40407).
13+
1114
## 5.12.0 (2024-05-09)
1215
- This release is compatible with Spring Boot 3.0.0-3.0.13, 3.1.0-3.1.8, 3.2.0-3.2.5. (Note: 3.0.x (x>13), 3.1.y (y>8) and 3.2.z (z>5) should be supported, but they aren't tested with this release.)
1316
- This release is compatible with Spring Cloud 2022.0.0-2022.0.5, 2023.0.0-2023.0.1. (Note: 2022.0.x (x>5) and 2023.0.y (y>1) should be supported, but they aren't tested with this release.)

sdk/spring/spring-cloud-azure-autoconfigure/src/main/java/com/azure/spring/cloud/autoconfigure/implementation/compatibility/AzureCompatibilityVerifierAutoConfiguration.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
* @since 4.0.0
1818
*/
1919
@Configuration(proxyBeanMethods = false)
20-
@ConditionalOnProperty(value = "spring.cloud.azure.compatibility-verifier.enabled", matchIfMissing = true)
20+
@ConditionalOnProperty(value = "spring.cloud.azure.compatibility-verifier.enabled")
2121
@AutoConfigureOrder
2222
@EnableConfigurationProperties(AzureCompatibilityVerifierProperties.class)
2323
public class AzureCompatibilityVerifierAutoConfiguration {

sdk/spring/spring-cloud-azure-autoconfigure/src/test/java/com/azure/spring/cloud/autoconfigure/implementation/compatibility/AzureCompatibilityVerifierAutoConfigurationTest.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,20 +21,21 @@ class AzureCompatibilityVerifierAutoConfigurationTest {
2121
@Test
2222
void testCompatibilityVerifierPropertiesDisabled() {
2323
this.contextRunner
24-
.withPropertyValues("spring.cloud.azure.compatibility-verifier.enabled=false")
2524
.run(context -> assertThat(context).doesNotHaveBean(AzureSpringBootVersionVerifier.class));
2625
}
2726

2827
@Test
2928
void testCompatibilityVerifierPropertiesEnabled() {
3029
this.contextRunner
30+
.withPropertyValues("spring.cloud.azure.compatibility-verifier.enabled=true")
3131
.run(context -> assertThat(context).hasSingleBean(AzureSpringBootVersionVerifier.class));
3232
}
3333

3434
@Test
3535
void testCompatibleSpringBootVersionCanSet() {
3636
String version = SpringBootVersion.getVersion();
3737
this.contextRunner
38+
.withPropertyValues("spring.cloud.azure.compatibility-verifier.enabled=true")
3839
.withPropertyValues(
3940
String.format("spring.cloud.azure.compatibility-verifier.compatible-boot-versions=%s", version)
4041
)

0 commit comments

Comments
 (0)