Skip to content

Commit e78e5da

Browse files
j82wealsur
andauthored
Diagnostics: Adds DurationInMs to StoreResult (#4462)
* Add StoreResponseStatistics startTime to diagnostics * Add latency in ms to make it easier to read. * Converted to DurationInMs * Remove start time * Update baseline file. --------- Co-authored-by: jakewilley_microsoft <--global> Co-authored-by: Matias Quaranta <[email protected]>
1 parent 52a5b83 commit e78e5da

File tree

2 files changed

+13
-0
lines changed

2 files changed

+13
-0
lines changed

Microsoft.Azure.Cosmos/src/Tracing/TraceWriter.TraceJsonWriter.cs

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -322,6 +322,17 @@ private void VisitStoreResponseStatistics(
322322
this.jsonWriter.WriteFieldName("ResponseTimeUTC");
323323
this.WriteDateTimeStringValue(storeResponseStatistics.RequestResponseTime);
324324

325+
this.jsonWriter.WriteFieldName("DurationInMs");
326+
if (storeResponseStatistics.RequestStartTime.HasValue)
327+
{
328+
TimeSpan latency = storeResponseStatistics.RequestResponseTime - storeResponseStatistics.RequestStartTime.Value;
329+
this.jsonWriter.WriteNumber64Value(latency.TotalMilliseconds);
330+
}
331+
else
332+
{
333+
this.jsonWriter.WriteNullValue();
334+
}
335+
325336
this.jsonWriter.WriteFieldName("ResourceType");
326337
this.jsonWriter.WriteStringValue(storeResponseStatistics.RequestResourceType.ToString());
327338

Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.Tests/BaselineTest/TestBaseline/TraceWriterBaselineTests.TraceData.xml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -317,6 +317,7 @@
317317
"StoreResponseStatistics": [
318318
{
319319
"ResponseTimeUTC": "9999-12-31T23:59:59.9999999",
320+
"DurationInMs": 315537897600000,
320321
"ResourceType": "Document",
321322
"OperationType": "Query",
322323
"RequestSessionToken": "42",
@@ -513,6 +514,7 @@
513514
"StoreResponseStatistics": [
514515
{
515516
"ResponseTimeUTC": "0001-01-01T00:00:00",
517+
"DurationInMs": null,
516518
"ResourceType": "Database",
517519
"OperationType": "Create",
518520
"LocationEndpoint": null,

0 commit comments

Comments
 (0)