Skip to content

Commit 0e158a8

Browse files
removed null check on 2 arguments because it was breaking other tests. I will maybe come back to it later.
1 parent d395a7d commit 0e158a8

File tree

2 files changed

+0
-52
lines changed

2 files changed

+0
-52
lines changed

Microsoft.Azure.Cosmos/src/GatewayStoreClient.cs

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -140,16 +140,6 @@ internal static async Task<DocumentClientException> CreateDocumentClientExceptio
140140
HttpResponseMessage responseMessage,
141141
IClientSideRequestStatistics requestStatistics)
142142
{
143-
if (responseMessage is null)
144-
{
145-
throw new ArgumentNullException(nameof(responseMessage));
146-
}
147-
148-
if (requestStatistics is null)
149-
{
150-
throw new ArgumentNullException(nameof(requestStatistics));
151-
}
152-
153143
if (!PathsHelper.TryParsePathSegments(
154144
resourceUrl: responseMessage.RequestMessage.RequestUri.LocalPath,
155145
isFeed: out _,

Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.Tests/GatewayStoreClientTests.cs

Lines changed: 0 additions & 42 deletions
Original file line numberDiff line numberDiff line change
@@ -246,48 +246,6 @@ public async Task TestCreateDocumentClientExceptionWhenMediaTypeIsApplicationJso
246246
Assert.IsNotNull(value: documentClientException.Error.Message);
247247
}
248248

249-
/// <summary>
250-
/// Testing CreateDocumentClientExceptionAsync when response message argument is null, then expects an argumentNullException.
251-
/// </summary>
252-
[TestMethod]
253-
[Owner("philipthomas-MSFT")]
254-
public async Task TestCreateDocumentClientExceptionWhenResponseMessageIsNullExpectsArgumentNullException()
255-
{
256-
ArgumentNullException argumentNullException = await Assert.ThrowsExceptionAsync<ArgumentNullException>(async () => await GatewayStoreClient.CreateDocumentClientExceptionAsync(
257-
responseMessage: default,
258-
requestStatistics: GatewayStoreClientTests.CreateClientSideRequestStatistics())
259-
);
260-
261-
Assert.IsNotNull(argumentNullException);
262-
Assert.AreEqual(expected: "Value cannot be null. (Parameter 'responseMessage')", actual: argumentNullException.Message);
263-
}
264-
265-
/// <summary>
266-
/// Testing CreateDocumentClientExceptionAsync when request statistics argument is null, then expects an argumentNullException.
267-
/// </summary>
268-
[TestMethod]
269-
[Owner("philipthomas-MSFT")]
270-
public async Task TestCreateDocumentClientExceptionWhenRequestStatisticsIsNullExpectsArgumentNullException()
271-
{
272-
HttpResponseMessage responseMessage = new(statusCode: HttpStatusCode.NotFound)
273-
{
274-
RequestMessage = new HttpRequestMessage(
275-
method: HttpMethod.Get,
276-
requestUri: @"https://pt_ac_test_uri.com/"),
277-
Content = new StringContent(
278-
content: JsonConvert.SerializeObject(
279-
value: new Error() { Code = HttpStatusCode.NotFound.ToString(), Message = "" })),
280-
};
281-
282-
ArgumentNullException argumentNullException = await Assert.ThrowsExceptionAsync<ArgumentNullException>(async () => await GatewayStoreClient.CreateDocumentClientExceptionAsync(
283-
responseMessage: responseMessage,
284-
requestStatistics: default)
285-
);
286-
287-
Assert.IsNotNull(argumentNullException);
288-
Assert.AreEqual(expected: "Value cannot be null. (Parameter 'requestStatistics')", actual: argumentNullException.Message);
289-
}
290-
291249
private static IClientSideRequestStatistics CreateClientSideRequestStatistics()
292250
{
293251
return new ClientSideRequestStatisticsTraceDatum(

0 commit comments

Comments
 (0)