Fix unstable test (#1396)

Author: martintmk

src/Polly.Core/Retry/RetryResilienceStrategy.cs

@@ -86,8 +86,7 @@ protected override async ValueTask<Outcome<T>> ExecuteCallbackAsync<TState>(Func
                 await DisposeHelper.TryDisposeSafeAsync(resultValue, context.IsSynchronous).ConfigureAwait(context.ContinueOnCapturedContext);
             }
 
-            // stryker disable once equality : no means to test this
-            // stryker disable once boolean : no means to test this
+            // stryker disable once all : no means to test this
             if (delay > TimeSpan.Zero)
             {
                 try

test/Polly.Core.Tests/Hedging/HedgingResilienceStrategyTests.cs

@@ -285,7 +285,12 @@ public async Task ExecuteAsync_EnsurePrimaryTaskCancelled_Ok()
 
         // assert
         _timeProvider.Advance(TimeSpan.FromHours(2));
-        cancelled.WaitOne(TimeSpan.FromSeconds(1)).Should().BeTrue();
+
+        await TestUtilities.AssertWithTimeoutAsync(() =>
+        {
+            cancelled.WaitOne(TimeSpan.FromMilliseconds(10)).Should().BeTrue();
+        });
+
         await task;
     }
 

test/Polly.Core.Tests/Retry/RetryResilienceStrategyTests.cs

@@ -157,21 +157,20 @@ public void Retry_Infinite_Respected()
     }
 
     [Fact]
-    public async Task RetryDelayGenerator_Respected()
+    public void RetryDelayGenerator_Respected()
     {
-        int retries = 0;
-        int generatedValues = 0;
-
+        var retries = 0;
+        var generatedValues = 0;
         var delay = TimeSpan.FromMilliseconds(120);
-        var provider = TimeProvider.System;
 
         _options.ShouldHandle = _ => PredicateResult.True;
         _options.RetryCount = 3;
         _options.BackoffType = RetryBackoffType.Constant;
 
-        _options.OnRetry = _ =>
+        _options.OnRetry = args =>
         {
             retries++;
+            args.Arguments.RetryDelay.Should().Be(delay);
             return default;
         };
         _options.RetryDelayGenerator = _ =>
@@ -180,16 +179,10 @@ public async Task RetryDelayGenerator_Respected()
             return new ValueTask<TimeSpan>(delay);
         };
 
-        var before = provider.GetUtcNow();
-
-        var sut = CreateSut(provider);
-        await sut.ExecuteAsync(_ => default);
+        CreateSut(TimeProvider.System).Execute(_ => { });
 
         retries.Should().Be(3);
         generatedValues.Should().Be(3);
-
-        var after = provider.GetUtcNow();
-        (after - before).Should().BeGreaterThanOrEqualTo(delay.Add(delay).Add(delay));
     }
 
     [Fact]