Fix time unit conversion in PhdTableView

Author: AndreyAkinshin

src/Perfolizer/Perfolizer.Tests/Phd/PhdTableTests.cs

@@ -0,0 +1,81 @@
+using JetBrains.Annotations;
+using Perfolizer.Metrology;
+using Perfolizer.Phd.Base;
+using Perfolizer.Phd.Dto;
+using Perfolizer.Phd.Presenting;
+using Perfolizer.Phd.Tables;
+using Perfolizer.Presenting;
+using Perfolizer.Tests.Infra;
+
+namespace Perfolizer.Tests.Phd;
+
+public class PhdTableTests(ITestOutputHelper output) : PhdTestsBase
+{
+    [Theory]
+    [MemberData(nameof(EntryDataKeys))]
+    public Task PhdTableTest(string key)
+    {
+        var entry = EntryDataMap[key];
+        var table = new PhdTable(entry);
+        var presenter = new StringPresenter();
+        new PhdMarkdownTablePresenter(presenter).Present(table, new PhdTableStyle());
+        return VerifyString(key, presenter.Dump());
+    }
+
+    private static readonly IDictionary<string, PhdEntry> EntryDataMap = new Dictionary<string, PhdEntry>
+    {
+        { "case01", Root().Add(Benchmark("Foo", "10ns"), Benchmark("Bar", "200ns")) },
+        { "case02", Root().Add(Benchmark("Foo", "10us"), Benchmark("Bar", "200us")) },
+        { "case03", Root().Add(Benchmark("Foo", "10ms"), Benchmark("Bar", "200ms")) },
+        { "case04", Root().Add(Benchmark("Foo", "10s"), Benchmark("Bar", "200s")) },
+        { "case05", Root().Add(Benchmark("Foo", "10ns"), Benchmark("Bar", "1us")) },
+        { "case06", Root().Add(Benchmark("Foo", "10ns"), Benchmark("Bar", "1s")) },
+    };
+
+    [UsedImplicitly] public static TheoryData<string> EntryDataKeys = TheoryDataHelper.Create(EntryDataMap.Keys);
+
+    private static PhdEntry Root() => new()
+    {
+        Meta = new PhdMeta
+        {
+            Table = new PhdTableConfig
+            {
+                ColumnDefinitions =
+                [
+                    new PhdColumnDefinition(".benchmark") { Cloud = "secondary" },
+                    new PhdColumnDefinition(".job") { Cloud = "secondary", Compressed = true },
+                    new PhdColumnDefinition("=center")
+                ]
+            }
+        },
+    };
+
+    private static PhdEntry Benchmark(string name, params string[] metrics)
+    {
+        var entry = new PhdEntry { Benchmark = new CustomBenchmark(name) };
+        for (int i = 0; i < metrics.Length; i++)
+        {
+            var measurement = Measurement.Parse(metrics[i]);
+            entry.Add(new PhdEntry
+            {
+                IterationIndex = i,
+                Value = measurement.NominalValue,
+                Unit = measurement.Unit
+            });
+        }
+        return entry;
+    }
+
+    private class CustomBenchmark(string name) : PhdBenchmark
+    {
+        public string Name { get; set; } = name;
+    }
+
+    private Task VerifyString(string key, string content)
+    {
+        output.WriteLine(content);
+        var settings = VerifyHelper.CreateSettings("Phd");
+        settings.UseParameters(key);
+        return Verify(content, settings);
+    }
+}

src/Perfolizer/Perfolizer.Tests/Phd/VerifiedFiles/Phd.PhdTableTest_key=case01.verified.txt

@@ -0,0 +1,4 @@
+| Name |   Center |
+|:-----|---------:|
+| Foo  |  10.0 ns |
+| Bar  | 200.0 ns |

src/Perfolizer/Perfolizer.Tests/Phd/VerifiedFiles/Phd.PhdTableTest_key=case02.verified.txt

@@ -0,0 +1,4 @@
+| Name |   Center |
+|:-----|---------:|
+| Foo  |  10.0 μs |
+| Bar  | 200.0 μs |

src/Perfolizer/Perfolizer.Tests/Phd/VerifiedFiles/Phd.PhdTableTest_key=case03.verified.txt

@@ -0,0 +1,4 @@
+| Name |   Center |
+|:-----|---------:|
+| Foo  |  10.0 ms |
+| Bar  | 200.0 ms |

src/Perfolizer/Perfolizer.Tests/Phd/VerifiedFiles/Phd.PhdTableTest_key=case04.verified.txt

@@ -0,0 +1,4 @@
+| Name |  Center |
+|:-----|--------:|
+| Foo  |  10.0 s |
+| Bar  | 200.0 s |

src/Perfolizer/Perfolizer.Tests/Phd/VerifiedFiles/Phd.PhdTableTest_key=case05.verified.txt

@@ -0,0 +1,4 @@
+| Name |    Center |
+|:-----|----------:|
+| Foo  |   10.0 ns |
+| Bar  | 1000.0 ns |

src/Perfolizer/Perfolizer.Tests/Phd/VerifiedFiles/Phd.PhdTableTest_key=case06.verified.txt

@@ -0,0 +1,4 @@
+| Name |          Center |
+|:-----|----------------:|
+| Foo  |         10.0 ns |
+| Bar  | 1000000000.0 ns |

src/Perfolizer/Perfolizer/Horology/TimeInterval.cs

@@ -32,6 +32,7 @@ public TimeInterval(double value, TimeUnit unit) : this(value * unit.BaseUnits)
     public double ToMinutes() => this / Minute;
     public double ToHours() => this / Hour;
     public double ToDays() => this / Day;
+    public double ToUnit(TimeUnit unit) => Nanoseconds / unit.BaseUnits;
 
     public static TimeInterval FromNanoseconds(double value) => Nanosecond * value;
     public static TimeInterval FromMicroseconds(double value) => Microsecond * value;

src/Perfolizer/Perfolizer/Phd/Tables/PhdTableView.cs

@@ -45,7 +45,7 @@ public PhdTableView(PhdTable table, PhdTableStyle style)
                     continue;
                 var unit = measurements.First().Unit;
 
-                if (unit is TimeUnit timeUnit)
+                if (unit is TimeUnit)
                 {
                     double[] values = measurements
                         .Select(m => m.AsTimeInterval()!.Value.Nanoseconds)
@@ -54,7 +54,8 @@ public PhdTableView(PhdTable table, PhdTableStyle style)
                     var bestUnit = TimeUnit.GetBestTimeUnit(values);
                     for (int rowIndex = 0; rowIndex < measurements.Length; rowIndex++)
                     {
-                        double valueInBestUnit = TimeUnit.Convert(measurements[rowIndex].NominalValue, timeUnit, bestUnit);
+                        var timeInterval = measurements[rowIndex].AsTimeInterval()!.Value;
+                        double valueInBestUnit = timeInterval.ToUnit(bestUnit);
                         measurements[rowIndex] = valueInBestUnit.WithUnit(bestUnit);
                         values[rowIndex] = valueInBestUnit;
                     }