Merge pull request #86 from gucio321/color-arg-names

AllenDang · web-flow · commit 91ad6387382a · 2023-01-13T13:18:22.000+08:00
extra types: rename NewColor's args from x,y,z,w to r,g,b,a
diff --git a/extra_types.go b/extra_types.go
@@ -67,13 +67,13 @@ type Color struct {
 	Value Vec4
 }
 
-func NewColor(x, y, z, w float32) Color {
+func NewColor(r, g, b, a float32) Color {
 	return Color{
 		Value: Vec4{
-			X: x,
-			Y: y,
-			Z: z,
-			W: w,
+			X: r,
+			Y: g,
+			Z: b,
+			W: a,
 		},
 	}
 }

Original file line number	Diff line number	Diff line change
`@@ -67,13 +67,13 @@ type Color struct {`
`67`	`67`	`Value Vec4`
`68`	`68`	`}`
`69`	`69`
`70`		`-func NewColor(x, y, z, w float32) Color {`
	`70`	`+func NewColor(r, g, b, a float32) Color {`
`71`	`71`	`return Color{`
`72`	`72`	`Value: Vec4{`
`73`		`- X: x,`
`74`		`- Y: y,`
`75`		`- Z: z,`
`76`		`- W: w,`
	`73`	`+ X: r,`
	`74`	`+ Y: g,`
	`75`	`+ Z: b,`
	`76`	`+ W: a,`
`77`	`77`	`},`
`78`	`78`	`}`
`79`	`79`	`}`