Skip to content

Commit 0209b8a

Browse files
committed
fix: fixed behavior when fetching single event that doesn't exist
1 parent cfa7e03 commit 0209b8a

File tree

2 files changed

+10
-5
lines changed

2 files changed

+10
-5
lines changed

aw_client/client.py

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -139,10 +139,16 @@ def get_event(
139139
self,
140140
bucket_id: str,
141141
event_id: int,
142-
) -> Event:
142+
) -> Optional[Event]:
143143
endpoint = f"buckets/{bucket_id}/events/{event_id}"
144-
event = self._get(endpoint).json()
145-
return Event(**event)
144+
try:
145+
event = self._get(endpoint).json()
146+
return Event(**event)
147+
except req.exceptions.HTTPError as e:
148+
if e.response.status_code == 404:
149+
return None
150+
else:
151+
raise
146152

147153
def delete_event(
148154
self,

tests/test_client.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -79,8 +79,7 @@ def test_full():
7979

8080
# Delete single event
8181
client.delete_event(bucket_name, fetched_events[1].id)
82-
with pytest.raises(ValueError):
83-
client.get_event(bucket_name, fetched_events[1].id)
82+
assert client.get_event(bucket_name, fetched_events[1].id) is None
8483

8584
# Test exception raising
8685
with pytest.raises(ValueError):

0 commit comments

Comments
 (0)