apache#2 #implementation of Unit Tests for BookieAuthZFactory: Added check on connection peer authorized id

Author: 0xmenna

bookkeeper-server/src/test/java/org/apache/bookkeeper/tls/BookieAuthZFactoryTest.java

@@ -117,6 +117,14 @@ public void testProviderInit() {
                 callBackMock.getAuthCode()
             );
 
+            if (authConfig.shouldAuthenticate()) {
+                Assert.assertNotEquals("The peer connection must have an authorized Id\n" +
+                    authConfig.toString(), connectionPeerMock.getAuthorizedId(), null);
+
+                String certRole = TestUtils.getRoles(authConfig.getAuthConfig())[0];
+                Assert.assertEquals("Certificate roles must be equals", certRole, connectionPeerMock.getAuthorizedId().getName());
+            }
+
         } catch (Exception e) {
             Assert.assertTrue("No exception was expected" +
                    ", but " + e.getClass().getName() + " has been thrown\n" +

bookkeeper-server/src/test/java/org/apache/bookkeeper/tls/mocks/ConnectionPeerMock.java

@@ -45,6 +45,16 @@ public ConnectionPeerMock mock() throws MockException {
             mockValidConnectionSocket();
             // This changes the behaviour between *VALID* and *INVALID* instances
             Mockito.when(connectionPeerMock.getProtocolPrincipals()).thenReturn(certificatesMock.getMockCertificates());
+
+            Mockito.doAnswer(invocation -> {
+                // Access the arguments passed to the method
+                BookKeeperPrincipal bookKeeperInputPrincipal = invocation.getArgument(0);
+
+                Mockito.when(connectionPeerMock.getAuthorizedId()).thenReturn(bookKeeperInputPrincipal);
+
+                return null;
+            }).when(connectionPeerMock).setAuthorizedId(any(BookKeeperPrincipal.class));
+
         }
 
         return this;